test windows builds with shared libs enabled #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuasing
reviewed
Feb 18, 2024
.github/workflows/windows.yml
Outdated
| @@ -13,7 +13,7 @@ concurrency: | |||
|
|
|||
| jobs: | |||
| test: | |||
| name: "${{ matrix.os }}/${{ matrix.arch }} (${{ matrix.generator }})" | |||
| name: "${{ matrix.os }}/${{ matrix.arch }}/shared ${{ matrix.shared }} (${{ matrix.generator }})" | |||
There was a problem hiding this comment.
I think formatting this as windows-2022/ARM64 (Visual Studio 17 2022, shared)/windows-2019/Win32 (Visual Studio 16 2019 could make it easier to understand. Maybe something like this would work?
Suggested change
| name: "${{ matrix.os }}/${{ matrix.arch }}/shared ${{ matrix.shared }} (${{ matrix.generator }})" | |
| name: "${{ matrix.os }}/${{ matrix.arch }} (${{ matrix.generator }}${{ matrix.shared == 'ON' && ', shared' || '' }})" |
There was a problem hiding this comment.
Sure, let's give it a try.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a failure in appveyor with shared libs enabled, do the same in workflows