-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite detection of ipv6-addresses & ipv6-networks to LibreNMS/Modules #15860
base: master
Are you sure you want to change the base?
Conversation
@Npeca75 does this has the same problem as the other one? |
Hi @Jellyfrog i understand your concern 🙂 for now, everything is looks good but, to be sure let me test it again with some "strange" prefixes |
Hi @Jellyfrog |
0d0c9ce
to
0778edd
Compare
@Npeca75 Thanks for starting work on this! We need to make some changes to make it align with the overall design of the new modules. You are missing a design pattern that puts all OS specific code in the OS classes within LibreNMS/OS. We do this by creating an interface for discovery/polling and implementing that on the OS. These functions return a collection of models. For this module, you would not need to create a polling interface of course. We can then use the Keyable interface on the model to sync them to the database with Check out the Isis.php module and others for an example. |
cd52e2f
to
bac8d12
Compare
done
it is over my head
so, i did: ok, half way you wanted ... but as i said, i will be glad if you rethink your demand or help me with co-authoring |
c05daf8
to
7d48101
Compare
proper handling of multiple IPv6 Addresses proper handling of IPv4 compatible IPv6 Addresses (tested on Jetstream and linux derivates) IPv6-MIB translate address origin IP-MIB translate address origin TPLINK-IPV6ADDR-MIB translate address origin refresh test data Signed-off-by: Peca Nesovanovic <[email protected]>
hi @murrant |
Thanks for continuing to work on this. You are getting closer.
Not sure if I missed anything there. |
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.