Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix for Incorrect Object Passing and Loop Control #5822

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdqst
Copy link

@mdqst mdqst commented Jan 21, 2025

Description

I noticed a couple of issues in the script:

  1. The function fix_unreachable_pub_warning was receiving m (part of the warning) instead of the full warning object, which caused unexpected behavior. I fixed this by passing the correct object.
  2. The script was using return to exit the loop when the code wasn't in the current workspace. I replaced it with continue to ensure the loop processes all warnings as intended.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant