make btree actually Poolable

gdx-ai/src/com/badlogic/gdx/ai/btree/BehaviorTree.java

@@ -172,11 +172,12 @@ public void notifyChildAdded (Task<E> task, int index) {
 
 	@Override
 	public void reset() {
+		// first call super reset to free child
+		super.reset();
 		removeListeners();
 		this.rootTask = null;
 		this.object = null;
 		this.listeners = null;
-		super.reset();
 	}
 
 	private static final class GuardEvaluator<E> extends Task<E> {

gdx-ai/src/com/badlogic/gdx/ai/btree/BranchTask.java

@@ -73,8 +73,9 @@ protected Task<E> copyTo (Task<E> task) {
 
 	@Override
 	public void reset() {
-		children.clear();
+		// first call super reset to free child
 		super.reset();
+		children.clear();
 	}
 
 }

gdx-ai/src/com/badlogic/gdx/ai/btree/Decorator.java

@@ -101,8 +101,9 @@ protected Task<E> copyTo (Task<E> task) {
 
 	@Override
 	public void reset() {
-		child = null;
+		// first call super reset to free child
 		super.reset();
+		child = null;
 	}
 
 }

gdx-ai/src/com/badlogic/gdx/ai/btree/LoopDecorator.java

@@ -68,8 +68,9 @@ public void childRunning (Task<E> runningTask, Task<E> reporter) {
 
 	@Override
 	public void reset() {
-		loop = false;
+		// first call super reset to free child
 		super.reset();
+		loop = false;
 	}
 
 }

gdx-ai/src/com/badlogic/gdx/ai/btree/SingleRunningChildBranch.java

@@ -132,10 +132,11 @@ protected Task<E>[] createRandomChildren () {
 
 	@Override
 	public void reset() {
+		// first call super reset to free child
+		super.reset();
 		this.currentChildIndex = 0;
 		this.runningChild = null;
 		this.randomChildren = null;
-		super.reset();
 	}
 
 }

gdx-ai/src/com/badlogic/gdx/ai/btree/Task.java

@@ -18,6 +18,7 @@
 
 import com.badlogic.gdx.ai.btree.annotation.TaskConstraint;
 import com.badlogic.gdx.utils.Pool.Poolable;
+import com.badlogic.gdx.utils.Pools;
 import com.badlogic.gdx.utils.reflect.ClassReflection;
 import com.badlogic.gdx.utils.reflect.ReflectionException;
 
@@ -69,7 +70,7 @@ public enum Status {
 	 *    };
 	 * </code>
 	 * </pre> */
-	public static TaskCloner TASK_CLONER = null;
+	public static TaskCloner TASK_CLONER = new PoolsTaskCloner();
 
 	/** The status of this task. */
 	protected Status status = Status.FRESH;
@@ -281,10 +282,32 @@ public Task<E> cloneTask () {
 
 	@Override
 	public void reset() {
+		// free child
+		if (TASK_CLONER != null) {
+			int childCount = getChildCount();
+			for (int i = 0; i < childCount; i++) {
+				TASK_CLONER.freeTask(getChild(i));
+			}
+		}
 		control = null;
 		guard = null;
 		status = Status.FRESH;
 		tree = null;
 	}
 
+	public static class PoolsTaskCloner implements TaskCloner{
+
+		@Override
+		public <T> Task<T> cloneTask(Task<T> task) {
+			Task poolTask = Pools.obtain(task.getClass());
+			task.copyTo(poolTask);
+			poolTask.guard = task.guard == null ? null : task.guard.cloneTask();
+			return poolTask;
+		}
+
+		@Override
+		public <T> void freeTask(Task<T> task) {
+			Pools.free(task);
+		}
+	}
 }

gdx-ai/src/com/badlogic/gdx/ai/btree/branch/DynamicGuardSelector.java

@@ -115,7 +115,8 @@ protected Task<E> copyTo (Task<E> task) {
 
 	@Override
 	public void reset() {
-		runningChild = null;
+		// first call super reset to free child
 		super.reset();
+		runningChild = null;
 	}
 }

gdx-ai/src/com/badlogic/gdx/ai/btree/branch/Parallel.java

@@ -241,12 +241,13 @@ public void execute(Parallel<?> parallel) {
 
 	@Override
 	public void reset() {
+		// first call super reset to free child
+		super.reset();
 		policy = Policy.Sequence;
 		orchestrator = Orchestrator.Resume;
 		noRunningTasks = true;
 		lastResult = null;
 		currentChildIndex = 0;
-		super.reset();
 	}
 
 	/** The enumeration of the policies supported by the {@link Parallel} task. */

gdx-ai/src/com/badlogic/gdx/ai/btree/decorator/Include.java

@@ -111,8 +111,9 @@ private Task<E> createSubtreeRootTask () {
 
 	@Override
 	public void reset() {
+		// first call super reset to free child
+		super.reset();
 		lazy = false;
 		subtree = null;
-		super.reset();
 	}
 }

gdx-ai/src/com/badlogic/gdx/ai/btree/decorator/Random.java

@@ -117,8 +117,9 @@ protected Task<E> copyTo (Task<E> task) {
 
 	@Override
 	public void reset() {
+		// first call super reset to free child
+		super.reset();
 		this.p = 0;
 		this.success = ConstantFloatDistribution.ZERO_POINT_FIVE;
-		super.reset();
 	}
 }

gdx-ai/src/com/badlogic/gdx/ai/btree/decorator/Repeat.java

@@ -100,8 +100,9 @@ protected Task<E> copyTo (Task<E> task) {
 
 	@Override
 	public void reset() {
+		// first call super reset to free child
+		super.reset();
 		count = 0;
 		times = null;
-		super.reset();
 	}
 }

gdx-ai/src/com/badlogic/gdx/ai/btree/decorator/SemaphoreGuard.java

@@ -128,9 +128,10 @@ protected Task<E> copyTo (Task<E> task) {
 
 	@Override
 	public void reset() {
+		// first call super reset to free child
+		super.reset();
 		name = null;
 		semaphore = null;
 		semaphoreAcquired = false;
-		super.reset();
 	}
 }

gdx-ai/src/com/badlogic/gdx/ai/btree/leaf/Wait.java

@@ -85,10 +85,11 @@ protected Task<E> copyTo (Task<E> task) {
 
 	@Override
 	public void reset() {
+		// first call super reset to free child
+		super.reset();
 		seconds = ConstantFloatDistribution.ZERO;
 		startTime = 0;
 		timeout = 0;
-		super.reset();
 	}
 
 }