Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Test Infrastructure and Namespace Organization in PHP GEDCOM Library #67

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Jan 11, 2025

This pull request was created by Sweep to resolve the following request by @curtisdelicata:

Fix unit tests

Continue chatting at https://sweep-chat-demo.vercel.app/c/bc77b4a0-e4bb-4351-942d-267f45329d1b.

Purpose

Improve the testing infrastructure and namespace organization for the PHP GEDCOM library by introducing a base test case and standardizing namespace usage across test files.

Description

This pull request introduces a centralized TestCase base class in the GedcomTest namespace, which provides a common foundation for test cases in the library. The changes include:

  • Creating a base TestCase class that extends PHPUnit's TestCase
  • Adding a utility method getTestFilePath() to simplify test file path resolution
  • Updating existing test files to use the new namespace and inherit from the base test case

Summary

  • Added new tests/TestCase.php with base test case infrastructure
  • Updated tests/WriterTest.php to:
    • Use GedcomTest namespace
    • Inherit from new base TestCase
  • Improved test file organization and path handling
  • Standardized namespace usage across test files

@curtisdelicata curtisdelicata merged commit cfc0eba into sweep/Refactor-and-Clean-Up-WriterTest-for-PHP-GEDCOM-Library Jan 11, 2025
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant