Fixed reinitialization of the window resize event thread #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vars end_resize_event_thread and resize_event_thread_ended were uninitialized in init. This prevented the resize event thread from running a second time if allegro was shutdown and then initialized again in the same application run.
|
This will probably work. As an aside, I wonder why we didn't use |
|
Thanks!
It's not using Allegro threads, but native Windows threads. I don't know why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge fixes a problem that occurs when initializing and running allegro multiple times in the same application session on Windows, i.e. during unit testing.
Vars end_resize_event_thread and resize_event_thread_ended were uninitialized in _al_win_init_window(). This prevented the resize event thread from running a second time because (end_resize_event_thread == true) as soon as it began.