Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2d H(curl) and H(div) formulations embedded in 3d space #4052

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

nmnobre
Copy link
Member

@nmnobre nmnobre commented Jan 19, 2025

No description provided.

@nmnobre nmnobre force-pushed the embedded branch 2 times, most recently from 2e93b77 to e5f423f Compare January 20, 2025 09:24
@moosebuild
Copy link

moosebuild commented Jan 20, 2025

Job Coverage, step Generate coverage on 52cdc44 wanted to post the following:

Coverage

2a4aed #4052 52cdc4
Total Total +/- New
Rate 62.33% 62.33% +0.00% 100.00%
Hits 72778 72790 +12 16
Misses 43987 43988 +1 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@nmnobre nmnobre force-pushed the embedded branch 4 times, most recently from 0eaf5f2 to bfe3bb6 Compare January 21, 2025 23:52
@roystgnr
Copy link
Member

From Slack just now:

Sorry for the wait but good news, the changes with the commit fixed the pure-2D with rotation eigenvalue discrepancy.

For reference, before the change, the first three non-zero eigenvalue were:

  • No Rotation: 5.7854890369939, 14.687709716912, 26.384752214715 / With Rotation: 8.6489407338644, 18.264283560678 25.571975954959

Now with the changes, the first three non-zero eigenvalue are:

  • No Rotation: 5.7854890369939, 14.687709716912, 26.384752214715 / With Rotation: 5.785489036994, 14.687709716912, 26.384752214714

Anything else we should wait for before merging?

@nmnobre
Copy link
Member Author

nmnobre commented Jan 23, 2025

Anything else we should wait for before merging?

Depends on how much more effort we are willing to put into this. I looked a bit into supporting what you call "mixed meshes" in the code in 8f01f22, in particular regarding output/visualisation. It seems to work, but I don't think we can escape modifying the interface to FEInterface::nodal_soln() to also take n_vec_dim, and I don't know if you're okay with that? Or do you have other ideas? Is this going to open a can of worms?

I also think Vector Ex. 3 looks a bit weird now, it would be nicer to allow an arbitrary rotation and evaluate the error on the rotated mesh (which we can do), but then if we don't do the above, we can't plot the result. I was thinking maybe I set the default to no rotation (i.e. the identity) and keep the output but add a note saying that if you rotate the mesh, you have to rotate the mesh back into the xy plane and hope the orientations still hold.

@nmnobre nmnobre changed the title Fix 2d H(curl) formulations embedded in 3d space Fix 2d H(curl) and H(div) formulations embedded in 3d space Jan 27, 2025
@nmnobre
Copy link
Member Author

nmnobre commented Jan 27, 2025

So, here's the plan: this PR will only fix the math, i.e. the previously incomplete Piola mappings. This avoids blocking it unnecessarily and guarantees users can do (even if not see) their work. A PR with more profound changes enabling proper error and visualisation output will follow (#4064).

@nmnobre nmnobre marked this pull request as ready for review January 27, 2025 13:06
@roystgnr roystgnr merged commit 0c39c8c into libMesh:devel Jan 31, 2025
20 checks passed
@nmnobre nmnobre deleted the embedded branch January 31, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants