-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2d H(curl) and H(div) formulations embedded in 3d space #4052
Conversation
2e93b77
to
e5f423f
Compare
0eaf5f2
to
bfe3bb6
Compare
From Slack just now:
Anything else we should wait for before merging? |
Depends on how much more effort we are willing to put into this. I looked a bit into supporting what you call "mixed meshes" in the code in 8f01f22, in particular regarding output/visualisation. It seems to work, but I don't think we can escape modifying the interface to I also think Vector Ex. 3 looks a bit weird now, it would be nicer to allow an arbitrary rotation and evaluate the error on the rotated mesh (which we can do), but then if we don't do the above, we can't plot the result. I was thinking maybe I set the default to no rotation (i.e. the identity) and keep the output but add a note saying that if you rotate the mesh, you have to rotate the mesh back into the xy plane and hope the orientations still hold. |
So, here's the plan: this PR will only fix the math, i.e. the previously incomplete Piola mappings. This avoids blocking it unnecessarily and guarantees users can do (even if not see) their work. A PR with more profound changes enabling proper error and visualisation output will follow (#4064). |
No description provided.