Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review #83

Merged
merged 6 commits into from
May 18, 2024
Merged

Code review #83

merged 6 commits into from
May 18, 2024

Conversation

hubertqc
Copy link
Collaborator

Quick code review:

  • Add (and document) the allow_springboot_rewrite_logs boolean.
  • Add the peer:recv permission on self when Sprinboot apps are allowed to connect to Springboot app.

@hubertqc hubertqc added documentation Improvements or additions to documentation enhancement New feature or request labels May 18, 2024
@hubertqc hubertqc self-assigned this May 18, 2024
@hubertqc hubertqc merged commit 6c72ea3 into main May 18, 2024
10 checks passed
@hubertqc hubertqc deleted the code_review branch May 18, 2024 09:23
Copy link
Collaborator

@Laurent-Gaillard Laurent-Gaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants