fix wifi status not properly displayed#6
Merged
rucoder merged 2 commits intolf-edge:mainfrom Jan 20, 2025
Merged
Conversation
- remove verbose log from kmsg task - fix typo in comment Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
- Some interfaces may not have MAC address e.g WiFi which is not properly configured Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
uncleDecart
reviewed
Jan 14, 2025
| println!("Unknown message type: {}", s); | ||
| panic!("Deserialization is not implemented!!!"); | ||
| } | ||
| _ => { |
Member
There was a problem hiding this comment.
Backward/forward compatibility? I mean what if new client will get old data and what if we use old client with new data?
Contributor
Author
There was a problem hiding this comment.
@uncleDecart this is a major problem. I need to create intermediate structures on EVE side to device EVE-Monitor API. now any change on eve side in internal structures breaks monitor
Member
There was a problem hiding this comment.
I'm 60% done with my research on switching to protocol-based communication in EVE with nkv and probably Protobuf, hang on there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.