Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: bump runners ubuntu version to latest available #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

uncleDecart
Copy link
Member

Accoring to [1] Ubuntu 20.04 runners in GitHub will be fully unsuppoerted by 2025-04-01. This commit bumps GitHub-provided runners to latest available Ubuntu 24.04

I am not changing runners to latest because fixed version guarantees stability of packages across workflow runs

[1] - actions/runner-images#11101

Accoring to [1] Ubuntu 20.04 runners in GitHub will be fully unsuppoerted
by 2025-04-01. This commit bumps GitHub-provided runners to latest available
Ubuntu 24.04

I am not changing runners to latest because fixed version guarantees
stability of packages across workflow runs

[1] - actions/runner-images#11101

Signed-off-by: Pavel Abramov <[email protected]>
upload-artifact@v3 was deprecated [1], so actions fail with it.
Bumping to v4 solves the problem

[1] - https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Signed-off-by: Pavel Abramov <[email protected]>
@uncleDecart
Copy link
Member Author

I don't think that the error was caused by my bump, not sure what's wrong

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark
Copy link
Contributor

@uncleDecart can you check if the test in
httpclient_test.go:222
is somehow breaking (without "www." prefix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants