Use whitelists rather then blacklists for header and query annotations #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lev,
It is hard to know upfront all possible security related headers (e.g. containing authentication tokens/user info etc) which risks leaking sensitive info into Zipkin traces.
My previous implementation took a blacklisting approach. Based on the above security concerns, I now realise it is more sensible to have use a whitelist for inclusion of query params and header values then a blacklist.