Fix golangci nits #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 13, 2018 11:14
|
Filed #69 to address the deprecated fields when someone has time. |
Pull Request Test Coverage Report for Build 363
💛 - Coveralls |
jsha
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the low hanging nits flagged by GolangCI.
It leaves three "megacheck" findings yet to be addressed in the
cttestsrv:All of the above are a result of google/trillian@0c12c84 - it looks like the
certificate-transparency-goctfe is still using the deprecated fields so I think we can ignore these for now. I think fixing it will require unserializing thelog_root []bytefrom the response and that's too fiddly for my low-hanging PR.