Make authz reuse expiry cutoff proportional to authz lifetime #8000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 640c949572424f88b02f4d5ecaad2488bc0086a2)
aarongable
commented
Feb 8, 2025
beautifulentropy
approved these changes
Feb 10, 2025
jprenken
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue to use a 24-hour cutoff for authzs with "long" lifetimes, so that our behavior is unchanged for authzs created with no profile specified. Use a 1-hour cutoff for authzs with "short" (less than 24-hour) lifetimes, so that we can reuse authzs created with modern profiles. Use linear interpolation between those values.
Fixes #7994