Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): revise playwright install for CI #4322

Merged
merged 1 commit into from
Mar 30, 2025

Conversation

puckowski
Copy link
Contributor

  • Revise Playwright install method for CI to avoid browser binary mismatch issues.

What:

Try to resolve CI issues where version of Playwright installed by CI on the fly would differ from package.json definition and cause browser binary mismatches.

Issue manifests like so:

╔═════════════════════════════════════════════════════════════════════════╗
║ Looks like Playwright Test or Playwright was just installed or updated. ║
║ Please run the following command to download new browsers:              ║
║                                                                         ║
║     pnpm exec playwright install                                        ║
║                                                                         ║
║ <3 Playwright Team                                                      ║
╚═════════════════════════════════════════════════════════════════════════╝

Why:

CI should be as reliable as possible.

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 11, 2025
@puckowski
Copy link
Contributor Author

Tried variations of

pnpm exec playwright install chromium --with-deps

and

pnpm add -D @playwright/test

but the only solution that seems to work is pinning the version of Playwright installed to match package.json.

* Revise Playwright install method for CI to avoid browser binary
  mismatch issues.
@matthew-dean
Copy link
Member

Yeah I think I saw a similar issue at work 🤔

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 30, 2025
@matthew-dean matthew-dean merged commit ddef3eb into less:master Mar 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants