-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: deprecation warnings for Less + monorepo chores #4319
✨ feat: deprecation warnings for Less + monorepo chores #4319
Conversation
Yeah, I think supporting Node versions 14-23 is unrealistic, especially if we're also trying to intersect with support on Windows / Mac. AND browsers. Node itself doesn't guarantee support that far back for its OWN versions. So, maybe it should be like this: Node support (Mac / Windows):
Browser support:
It looks like we may be able to set this up in a maintainable way by using lts identifiers. In other words, I think our matrix could be Btw, our current ci workflow has a lot of copy / paste. It can be simplified / reduced using a reusable workflow. You really only need one set of steps that defines setup / testing. Everything else should be configurable via matrices and parameters. Also... 🤔 I think it's configured incorrectly, even beyond copy / paste. For instance, |
…ean/less.js into chore/add-deprecation-warnings
Hey, I think I got this to work with dynamic versions! Check it out. I added one additional LTS version (v16 currently) for safety. Oh I also fixed this:
There's now just one simple workflow. |
@puckowski @iChenLei opinions on the deprecation notices in general? |
Cool ! |
Sorry, I did not have access to a working computer for a bit. I will still review this PR for any feedback/improvements even though it is already merged. @matthew-dean |
|
I appreciate that! I wasn't going to create a release immediately in case you had a chance to look. |
I tested these changes locally and things are working as expected so far. I like the Aside from a potential |
What:
quiet
option to silence warningsWhy:
Checklist: