Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Trainable interface and add TrainingOptions #599

Merged
merged 23 commits into from
Jan 11, 2025

Conversation

mdekstrand
Copy link
Member

This moves Trainable to a new lenskit.training module, and adds an options parameter of type TrainingOptions to provide options to the model training process, including a train-time RNG.

@mdekstrand mdekstrand added internals Internal infrastructure (parallelism, math, etc.) pipeline LensKit pipeline abstraction labels Jan 11, 2025
@mdekstrand mdekstrand added this to the 2025.1 milestone Jan 11, 2025
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 95.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.96%. Comparing base (204dcee) to head (60e0972).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/basic/history.py 80.00% 2 Missing ⚠️
lenskit/lenskit/pipeline/_impl.py 90.00% 2 Missing ⚠️
lenskit/lenskit/basic/candidates.py 85.71% 1 Missing ⚠️
lenskit/lenskit/basic/popularity.py 90.00% 1 Missing ⚠️
lenskit/lenskit/testing/_components.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files         106      107    +1     
  Lines        6567     6587   +20     
=======================================
+ Hits         5908     5926   +18     
- Misses        659      661    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand force-pushed the feature/training-rework branch from 282c681 to 0a5190b Compare January 11, 2025 21:34
@mdekstrand mdekstrand merged commit 1954efb into lenskit:main Jan 11, 2025
39 checks passed
@mdekstrand mdekstrand deleted the feature/training-rework branch January 11, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal infrastructure (parallelism, math, etc.) pipeline LensKit pipeline abstraction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant