-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Trainable interface and add TrainingOptions #599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdekstrand
added
internals
Internal infrastructure (parallelism, math, etc.)
pipeline
LensKit pipeline abstraction
labels
Jan 11, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 89.96% 89.96%
=======================================
Files 106 107 +1
Lines 6567 6587 +20
=======================================
+ Hits 5908 5926 +18
- Misses 659 661 +2 ☔ View full report in Codecov by Sentry. |
mdekstrand
force-pushed
the
feature/training-rework
branch
from
January 11, 2025 21:34
282c681
to
0a5190b
Compare
This was referenced Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
Trainable
to a newlenskit.training
module, and adds anoptions
parameter of typeTrainingOptions
to provide options to the model training process, including a train-time RNG.