Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Pipeline into private submodule and improve documentation #595

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

mdekstrand
Copy link
Member

This moves Pipeline around a bit:

  • Pipeline goes into lenskit.pipeline._impl
  • Pipeline warnings and errors are moved to lenskit.diagnostics
  • Improve pipeline documentation
  • Add support to get_logger to strip out private components of logger names to simplify use of get_logger(__name__) in private implementation modules

@mdekstrand mdekstrand added the pipeline LensKit pipeline abstraction label Jan 8, 2025
@mdekstrand mdekstrand added this to the 2025.1 milestone Jan 8, 2025
@mdekstrand mdekstrand self-assigned this Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 95.85987% with 13 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (91216fd) to head (42a06c8).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/pipeline/_impl.py 95.54% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
+ Coverage   90.72%   90.74%   +0.02%     
==========================================
  Files         106      107       +1     
  Lines        6531     6547      +16     
==========================================
+ Hits         5925     5941      +16     
  Misses        606      606              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 42a06c8 into lenskit:main Jan 9, 2025
39 checks passed
@mdekstrand mdekstrand deleted the feature/pipeline-impl-module branch January 9, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipeline LensKit pipeline abstraction
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant