Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory check in save_parquet #593

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

samiravaez
Copy link
Contributor

Added directory existence check in the save_parquet method to ensure the parent directory exists before saving the file. Also, added a test to validate this functionality

Copy link
Member

@mdekstrand mdekstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We'll make sure the tests pass before merging, but should be good to go.

@mdekstrand
Copy link
Member

@samiravaez these test failures are not due to your code, but are due to a dependency bug that I fixed on main yesterday. Merge the latest main into your feature branch and re-push to make sure the tests pass.

@mdekstrand mdekstrand added this to the 2025.1 milestone Jan 7, 2025
@mdekstrand mdekstrand added enhancement data Data management support. labels Jan 7, 2025
@mdekstrand mdekstrand self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (9909d6b) to head (cb9d14b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #593   +/-   ##
=======================================
  Coverage   90.71%   90.72%           
=======================================
  Files         106      106           
  Lines        6529     6531    +2     
=======================================
+ Hits         5923     5925    +2     
  Misses        606      606           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 91216fd into lenskit:main Jan 7, 2025
39 checks passed
@samiravaez samiravaez deleted the add-feature branch January 8, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Data management support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants