Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 12Factor-style JSON logging #591

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

mdekstrand
Copy link
Member

This adds support for configuring the logger to write JSON logging to the terminal.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.71%. Comparing base (f3e2274) to head (bcccbad).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/logging/tracing.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #591   +/-   ##
=======================================
  Coverage   90.71%   90.71%           
=======================================
  Files         106      106           
  Lines        6527     6529    +2     
=======================================
+ Hits         5921     5923    +2     
  Misses        606      606           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 51ef299 into lenskit:main Jan 6, 2025
33 of 39 checks passed
@mdekstrand mdekstrand deleted the feature/json-logging branch January 6, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant