Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource measurement for “tasks” #548

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

mdekstrand
Copy link
Member

This adds a task concept to logging, so that we can measure resource usage.

@mdekstrand mdekstrand added the internals Internal infrastructure (parallelism, math, etc.) label Dec 13, 2024
@mdekstrand mdekstrand added this to the 2025.1 milestone Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 87.85047% with 26 lines in your changes missing coverage. Please review.

Project coverage is 90.30%. Comparing base (19f03d5) to head (a3bd64d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/logging/tasks.py 84.92% 19 Missing ⚠️
lenskit/lenskit/logging/resource.py 92.00% 4 Missing ⚠️
lenskit/lenskit/logging/monitor.py 83.33% 2 Missing ⚠️
lenskit/lenskit/logging/worker.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
+ Coverage   90.23%   90.30%   +0.06%     
==========================================
  Files          98      100       +2     
  Lines        5756     5950     +194     
==========================================
+ Hits         5194     5373     +179     
- Misses        562      577      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 114b5da into lenskit:main Dec 13, 2024
34 of 35 checks passed
@mdekstrand mdekstrand deleted the feature/measure-run branch December 13, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal infrastructure (parallelism, math, etc.)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant