Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split perf bug and progress bar bug #546

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

mdekstrand
Copy link
Member

This fixes a small bug in progress bar display, and dramatically speeds up split performance.

@mdekstrand mdekstrand added this to the 2025.1 milestone Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (0e27ced) to head (19f03d5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/logging/progress/_rich.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #546   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files          98       98           
  Lines        5756     5756           
=======================================
  Hits         5194     5194           
  Misses        562      562           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 19f03d5 into lenskit:main Dec 11, 2024
34 of 35 checks passed
@mdekstrand mdekstrand deleted the tweak/perf branch December 11, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant