Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feedback setting name for item KNN #544

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

mdekstrand
Copy link
Member

There was a typo in item KNN so it incorrectly saved the settings. This fixes the problem.

@mdekstrand mdekstrand added bug components LensKit recommendation components labels Dec 7, 2024
@mdekstrand mdekstrand added this to the 2025.1 milestone Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.37%. Comparing base (8cf227c) to head (2c49ff8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files          98       98           
  Lines        5738     5738           
=======================================
  Hits         5186     5186           
  Misses        552      552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 0823c7d into lenskit:main Dec 7, 2024
35 checks passed
@mdekstrand mdekstrand deleted the fix/item-implicit branch December 7, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components LensKit recommendation components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant