Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy random code #351

Merged
merged 25 commits into from
Dec 13, 2023

Conversation

mdekstrand
Copy link
Member

@mdekstrand mdekstrand commented Dec 13, 2023

This does several cleanups to the RNG code:

  • Remove deprecated wrappers to Seedbank RNG functionality
  • Remove use of and support for legacy NumPy RandomState, per SPEC0 (Pandas 1.4 added support for the modern NumPy RNG architecture)
  • Clean up tests and documentation around RNG usage

Also cleans up some legacy cruft from conftest.py.

@mdekstrand mdekstrand added the internals Internal infrastructure (parallelism, math, etc.) label Dec 13, 2023
@mdekstrand mdekstrand added this to the 0.15.0 milestone Dec 13, 2023
@mdekstrand mdekstrand self-assigned this Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e21ca83) 90.85% compared to head (572cdbd) 90.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   90.85%   90.88%   +0.03%     
==========================================
  Files          38       38              
  Lines        3116     3095      -21     
==========================================
- Hits         2831     2813      -18     
+ Misses        285      282       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 7ab675c into lenskit:main Dec 13, 2023
17 checks passed
@mdekstrand mdekstrand deleted the tweak/drop-deprecated-random branch December 13, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal infrastructure (parallelism, math, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant