Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Broken Build on Node >= 12 #108

Merged
merged 2 commits into from
Dec 30, 2020
Merged

Fix Broken Build on Node >= 12 #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b07ccba
Fix Graceful FS version in older gulp
isopropylcyanide Dec 5, 2020
354e744
Remove Gulp v4 dependency
isopropylcyanide Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"jit-grunt": "^0.10.0"
},
"scripts": {
"preinstall": "npx npm-force-resolutions",
"test": "echo \"Error: no test specified\" && exit 1",
"postinstall": "bower install",
"build": "grunt && cd dist && tar cvzf kafka-connect-ui.tar.gz ."
Expand All @@ -34,5 +35,9 @@
"bugs": {
"url": "https://github.com/Landoop/kafka-connect-ui/issues"
},
"homepage": "https://github.com/Landoop/kafka-connect-ui#readme"
"homepage": "https://github.com/Landoop/kafka-connect-ui#readme",
"resolutions": {
"graceful-fs": "^4.2.4"
}
Comment on lines +39 to +41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you already upgraded to Gulp version 4. From the Documentation, I see that resolutions are only needed if you want to work with Node > 12 and Gilp 3.x.x. Can you please try to remove it and see what happens?? Thanks for the PR.. 🚀

Copy link
Contributor Author

@isopropylcyanide isopropylcyanide Dec 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks for pointing it out. The build works as expected. I've removed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Will merge it soon!! And sorry for the delay in getting back to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot :)

}