Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added editor instance as onReady function parameter $evalAsync #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added editor instance as onReady function parameter $evalAsync #28

wants to merge 1 commit into from

Conversation

JonnyFox
Copy link

  • Refactor to $scope.$evalAsync (avoid setTimeout)
  • Added editor instance as parameter of onReady function

@factorymindsc
- Added editor instance inReady
3701c83 
 - Refactored to $scope.$evalAsync
@stefanullinger
Copy link

Hi,

is this project still alive? Can somebody merge this PR? I need the same improvements in one of my projects.

Thanks!
Stefan

@Yvem
Copy link
Contributor

Yvem commented Jan 4, 2016

I'm reviewing it but note that tests are broken...

@JBustin
Copy link

JBustin commented Nov 2, 2016

@JonnyFox up for the unit tests

@JBustin JBustin self-assigned this Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JBustin JBustin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JonnyFox @stefanullinger @Yvem @JBustin @factorymindsc