Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby Rust translation #305

Open
wants to merge 6 commits into
base: swahili-translation
Choose a base branch
from

Conversation

collinskoech11
Copy link

@collinskoech11 collinskoech11 commented Oct 2, 2023

Make sure you go through the Contributing guide.

Please delete options that are not relevant.

Title

This pull request (PR) is made in reference to:

Description

What does this PR do?

Recommendations for how to test this?

Motivation and Context

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Testing

  • My submission passes the tests?
    • If you did additional testing, please describe in detail how you tested your changes
  • I added new tests for core changes, as applicable?

Screenshots (if appropriate):

@welcome
Copy link

welcome bot commented Oct 2, 2023

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@madiedgar
Copy link
Member

Hi @collinskoech11, I'd love to add you as a translation contributor. Follow the instructions in #191 to add a translation review. When that gets merged in, I'll merge this one in as well! 😄

Copy link
Author

@collinskoech11 collinskoech11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madiedgar @wambugucoder kindly review.

locale/sw.yml Outdated Show resolved Hide resolved
locale/sw.yml Outdated Show resolved Hide resolved
locale/sw.yml Outdated Show resolved Hide resolved
Copy link
Member

@madiedgar madiedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @collinskoech11, this is a great start 👍🏾

Due to the nature of the repo, adding a translation actually requires 2 different PR's:

  1. The translation into the language-translation branch for a specific language
  2. The all-contributors update to master

I'd suggest creating another PR to add your actual translations sw.yml to the swahili branch and then we'll revisit this one to add you to the all-contributors list on the master branch. :)

Some Helpful Tips
When adding a translation, you'll need to start from the swahili-translation branch on your local fork and create a new branch from that specific language's branch (not from the master branch). you can then add your opinion of the translations for the keywords in relation to previous reviewers. I raised #306 to update the style of the locale/sw.yml so it is aligned with our updated style guide (like how it's explained in the #191).

Let me know if you have any questions.

@madiedgar madiedgar changed the base branch from swahili-translation to master October 4, 2023 03:16
@collinskoech11 collinskoech11 changed the base branch from master to swahili-translation October 4, 2023 05:56
@collinskoech11 collinskoech11 changed the title update all-contributors.md Ruby Rust swahili translation Oct 4, 2023
@collinskoech11 collinskoech11 changed the title Ruby Rust swahili translation Ruby Rust translation Oct 4, 2023
@collinskoech11 collinskoech11 changed the base branch from swahili-translation to master October 4, 2023 06:03
@collinskoech11 collinskoech11 changed the base branch from master to swahili-translation October 4, 2023 06:04
Copy link
Contributor

@wambugucoder wambugucoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elsif: "au-kama"
end: "maliza"
ensure: "hakikisha"
false: "uwongo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing the keyword translations for Ruby and Rust. Could you update the format to the new style for your translations? This will make it easier for people to add their review for the translation.

  False: "uwongo"
    # ✅ @collinskoech11 

@madiedgar
Copy link
Member

@collinskoech11 would you be able to raise another PR for Python keywords and builtin translations as well? Our first priority is getting Python reviewed by 5 more people. By the end, it might look like this:

  False: "uwongo"
    # ✅ @wambugucoder
    # ✅ @collinskoech11
    # 🤔 @user1 what about this word ______
    # ❓ @user2 not sure this is the right word
    # ✅ @user3 
    # ✅ @user4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants