-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby Rust translation #305
base: swahili-translation
Are you sure you want to change the base?
Ruby Rust translation #305
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Hi @collinskoech11, I'd love to add you as a translation contributor. Follow the instructions in #191 to add a translation review. When that gets merged in, I'll merge this one in as well! 😄 |
updated swahili translation file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madiedgar @wambugucoder kindly review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @collinskoech11, this is a great start 👍🏾
Due to the nature of the repo, adding a translation actually requires 2 different PR's:
- The translation into the
language-translation
branch for a specific language - The all-contributors update to
master
I'd suggest creating another PR to add your actual translations sw.yml
to the swahili branch and then we'll revisit this one to add you to the all-contributors list on the master branch. :)
Some Helpful Tips
When adding a translation, you'll need to start from the swahili-translation
branch on your local fork and create a new branch from that specific language's branch (not from the master
branch). you can then add your opinion of the translations for the keywords in relation to previous reviewers. I raised #306 to update the style of the locale/sw.yml
so it is aligned with our updated style guide (like how it's explained in the #191).
Let me know if you have any questions.
Signed-off-by: Collins Koech <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
elsif: "au-kama" | ||
end: "maliza" | ||
ensure: "hakikisha" | ||
false: "uwongo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing the keyword translations for Ruby and Rust. Could you update the format to the new style for your translations? This will make it easier for people to add their review for the translation.
False: "uwongo"
# ✅ @collinskoech11
@collinskoech11 would you be able to raise another PR for Python keywords and builtin translations as well? Our first priority is getting Python reviewed by 5 more people. By the end, it might look like this:
|
Title
This pull request (PR) is made in reference to:
Description
Motivation and Context
Checklist:
Testing
Screenshots (if appropriate):