-
Notifications
You must be signed in to change notification settings - Fork 34
Update/500 #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/500 #326
Conversation
dlmsr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TamaroWalter,
thanks for the PR. Here is the review you requested.
-
commit message of 9883f33 does not match the diff,
better: ‘Delete trailing whitespace in PR template’ -
Squash 487ce90 and 1a5bda4 into one commit with message:
Split locallib.php apart and use class autoloading Moodle supports a class autoloading mechanism. Move the classes defined in locallib.php into their own files under classes/.Also there is something other going on in these commits, namely some
code formatting. Please refrain from doing so in the future. I know
it’s sometimes hard to resist 😉 -
Squash fec5eb3 (improve changes.md styling) and ad6f935 (add
changes.md) but before edit fec5eb3 (improve changes.md styling) and
delete the trailing whitespace. -
1622eb7 does more than adding new coverage annotations. Please split
in this case.
Ideally we should then end up with the following history:
* Sync with Learnweb's centralized pull request template
* Add new coverage annotations to unit tests
* Change indentation (why though?)
* Fix typo in method name of class ratingallocate
* Merge nested if into single if
* Add CHANGES.md
* Split locallib.php apart and use class autoloading
* Delete trailing whitespace in PR template
We should go for a follow-up PR that moves the strategies also into
classes/ and into a common namespace. As well as some other classes
which do not reside under classes/. WDYT?
I will add some additional comments to some changes in the GitHub diff
for this PR.
dlmsr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
I know it's a lot 🤕 sorry
This reverts commit 9a93fad. The pull request template is added and kept in sync by a bot which is defined in the repository for the centralized workflows.
Moodle supports a class autoloading mechanism. Move the classes defined in locallib.php into their own files under classes/.
add the link to the adressed issue and remove unnecessary information about changes in the locallib
Add missing cover annotations and add new coverage annotation style for phpunit 12
Replace qualifiers with imports and long if-chains with the php match-statement. Make array definitions more compact.
📋 Kind of PR
🧩 Description
This PR updates ratingallocate to the new moodle version. This includes:
Additionally:
✅ Checklist
Please confirm the following (check all that apply):
phpunitand/orbehattests that cover my changes or additions.var_dump()orvar_exportor any other debugging statements that should not appear on the productive branch.db/upgrade.phpand updated theversion.php.version.phpand added the new moodle version to the workflow file. I ran all tests thoroughly checking for errors.🧱 Related Issue
🗒️ Additional Notes