Skip to content

new class for interacting with posts #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 60 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
715e132
new class for interacting with posts
TamaroWalter Jun 13, 2023
6eece3e
WIP: class diagram for new structure
TamaroWalter Jun 19, 2023
e6298dd
WIP: class diagram
TamaroWalter Jun 20, 2023
82fd83e
WIP: better class diagram
TamaroWalter Jun 20, 2023
be057c9
WIP write post_control class
TamaroWalter Jun 26, 2023
f9bac43
First stage of post_control ready
TamaroWalter Jun 27, 2023
3b7842d
Merge branch 'master' into redesign/post
TamaroWalter Jul 3, 2023
c100a20
WIP: writing new post class for interacting with posts
TamaroWalter Jul 3, 2023
c4c3128
run grunt
TamaroWalter Jul 5, 2023
c8ace61
WIP: building post class
TamaroWalter Jul 5, 2023
c120ca4
WIP: building the new post class
TamaroWalter Jul 10, 2023
fad5329
WIP: new post class. Adjusting print function
TamaroWalter Jul 11, 2023
c54fb26
new Discussion class as part of the redesign
TamaroWalter Jul 13, 2023
66f77e5
WIP: updating discussion functions in new discussion.php
TamaroWalter Jul 17, 2023
437e6ea
WIP: new functions in discussion and post for editing posts
TamaroWalter Jul 18, 2023
0e3c972
WIP: post and discussion class ready, post_control refactoring
TamaroWalter Jul 21, 2023
5ea9221
WIP: new post.php file, post control is almost ready
TamaroWalter Jul 26, 2023
70ac6d6
new post.php complete
TamaroWalter Jul 27, 2023
d99ec28
new post structure ready
TamaroWalter Jul 28, 2023
b71565e
change includes
NinaHerrmann Jul 28, 2023
0eed562
WIP: fixing errors
TamaroWalter Jul 28, 2023
ebc4be9
Testing new structure: replies works
TamaroWalter Aug 3, 2023
8961316
first testing completed and successful. Test classes still needed
TamaroWalter Aug 9, 2023
29e3a09
little compatibility fixes with new post structure
TamaroWalter Aug 10, 2023
5b61489
deleting unnecessary functions in the locallib
TamaroWalter Aug 10, 2023
1ffeb5b
new post_test class
TamaroWalter Aug 17, 2023
104a8dc
new phpunit tests for discussion class
TamaroWalter Aug 18, 2023
95b665c
behat fails in older versions fixed
TamaroWalter Sep 7, 2023
e5131ea
capability fixed in post_control
TamaroWalter Sep 7, 2023
8ffc2f0
replace html with html_writer
TamaroWalter Sep 7, 2023
ac61679
edit a discussion subject fixed
TamaroWalter Sep 7, 2023
aedb836
moodlechecker fixes
TamaroWalter Sep 7, 2023
1c7c208
function in locallib changed for behat testing environment
TamaroWalter Sep 7, 2023
2379466
fix in post control for behat testing environment
TamaroWalter Sep 7, 2023
eaa2611
code cleaning: long array syntax to short array syntax
TamaroWalter Oct 27, 2023
a6917ad
codechecker fix in subscriptions_test
TamaroWalter Nov 2, 2023
ef6bef8
grammar fix in comments
TamaroWalter Nov 30, 2023
0e75bcd
Merge branch 'master' into redesign/post
TamaroWalter Apr 23, 2024
c03c799
Change anonymous name from Anonymous to Questioner in attachment
TamaroWalter Apr 23, 2024
0a6d181
fix for behat test
TamaroWalter Apr 26, 2024
9b99c25
pull from update/m4.4
TamaroWalter May 30, 2024
0eb6130
check for php version
TamaroWalter May 30, 2024
121957e
use moodle function to check php version
TamaroWalter May 30, 2024
6eb48c4
merge with current main
Jul 7, 2025
c7dedfa
Sync with Learnweb's centralized pull request template
github-actions[bot] Jul 7, 2025
7fe2ba9
code cleaning
Jul 7, 2025
e072457
fix merge problems
Jul 7, 2025
d19fe7f
delete build files
Jul 7, 2025
f746d8b
build new js files
Jul 7, 2025
2898745
rebuild js files
Jul 7, 2025
7e48736
rebuild min js files
TamaroWalter Jul 7, 2025
f44ff11
WIP: rebuild min files
Jul 7, 2025
c297e61
remove old builds
Jul 7, 2025
a048305
WIP: rebuild min files
Jul 7, 2025
f2d5a8f
delete min files
Jul 7, 2025
6c8c27c
rebuild min files
Jul 7, 2025
f14eaf1
change js content
Jul 7, 2025
1413737
allow grunt error
Jul 7, 2025
13c58af
use right workflow configuration
Jul 7, 2025
bb339be
allow grunt error
Jul 7, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
> **Note:** Please fill out all required sections and remove irrelevant ones.
### 🔀 Purpose of this PR:

- [ ] Fixes a bug
- [ ] Updates for a new Moodle version
- [ ] Adds a new feature of functionality
- [ ] Improves or enhances existing features
- [ ] Refactoring: restructures code for better performance or maintainability
- [ ] Testing: add missing or improve existing tests
- [ ] Miscellaneous: code cleaning (without functional changes), documentation, configuration, ...

---

### 📝 Description:

Please describe the purpose of this PR in a few sentences.

- What feature or bug does it address?
- Why is this change or addition necessary?
- What is the expected behavior after the change?

---

### 📋 Checklist

Please confirm the following (check all that apply):

- [ ] I have `phpunit` and/or `behat` tests that cover my changes or additions.
- [ ] Code passes the code checker without errors and warnings.
- [ ] Code passes the moodle-ci/cd pipeline on all supported Moodle versions or the ones the plugin supports.
- [ ] Code does not have `var_dump()` or `var_export` or any other debugging statements (or commented out code) that
should not appear on the productive branch.
- [ ] Code only uses language strings instead of hard-coded strings.
- [ ] If there are changes in the database: I updated/created the necessary upgrade steps in `db/upgrade.php` and
updated the `version.php`.
- [ ] If there are changes in javascript: I build new `.min` files with the `grunt amd` command.
- [ ] If it is a Moodle update PR: I read the release notes, updated the `version.php` and the `CHANGES.md`.
I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
changes in the plugins UI.

---

### 🔍 Related Issues

- Related to #[IssueNumber]

---

### 🧾📸🌐 Additional Information (like screenshots, documentation, links, etc.)

Any other relevant information.

---
30 changes: 20 additions & 10 deletions .github/workflows/config.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,22 @@
{
"main-moodle": "MOODLE_405_STABLE",
"moodle-plugin-ci": "4.5.7",
"main-moodle": "MOODLE_500_STABLE",
"main-php": "8.3",
"moodle-php": {
"MOODLE_401_STABLE": ["8.0", "8.1"],
"MOODLE_402_STABLE": ["8.1", "8.2"],
"MOODLE_403_STABLE": ["8.1", "8.2"],
"MOODLE_404_STABLE": ["8.2", "8.3"],
"MOODLE_405_STABLE": ["8.1", "8.2", "8.3"]
},
"moodle-plugin-ci": "4.5.5"
}
"main-db": "pgsql",
"moodle-testmatrix": {
"MOODLE_401_STABLE": {
"php": ["8.0", "8.1"]
},
"MOODLE_404_STABLE": {
"php": ["8.1", "8.2", "8.3"]
},
"MOODLE_405_STABLE": {
"php": ["8.1", "8.2", "8.3"],
"db": ["pgsql", "mariadb", "mysqli"]
},
"MOODLE_500_STABLE": {
"php": ["8.2", "8.3", "8.4"],
"db": ["pgsql", "mariadb", "mysqli"]
}
}
}
1 change: 1 addition & 0 deletions .github/workflows/moodle-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ jobs:
uses: learnweb/moodle-workflows-learnweb/.github/workflows/moodle-ci.yml@main
with:
allow-mustache-lint-error: true
allow-grunt-error: true
4 changes: 2 additions & 2 deletions amd/build/activityhelp.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion amd/build/activityhelp.min.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions amd/build/rating.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading