Skip to content

feat(docker-pack): allow killing PHP commands #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

lucasmirloup
Copy link
Member

@lucasmirloup lucasmirloup commented Feb 24, 2025

Without init: true, Ctrl+C does nothing on PHP CLI commands (sf make:foobar for example).
See https://docs.docker.com/reference/compose-file/services/#init

Copy link
Member

@pierreboissinot pierreboissinot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, chez moi ça marche déjà bien ctrl+C

@lucasmirloup
Copy link
Member Author

ok, chez moi ça marche déjà bien ctrl+C

Yes, ça dépend des cas : certaines commandes démarrées à l'aide de docker compose run dans les .spells ne gèrent pas bien les SIGTERM par défaut, et ça empêche de les kill facilement 🫤

@thislg thislg merged commit 1db8fcb into main Mar 3, 2025
@thislg thislg deleted the feat/docker-pack-php-kill-commands branch March 3, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants