Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker-pack): .spells: add to manifest, allow killing long Docker processes #49

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

lucasmirloup
Copy link
Member

Needed for some processes like Symfony Messenger consume for example.

@lucasmirloup lucasmirloup added bug Something isn't working docker-pack labels Oct 15, 2024
@lucasmirloup lucasmirloup requested a review from thislg October 15, 2024 14:32
@lucasmirloup lucasmirloup self-assigned this Oct 15, 2024
Copy link
Member

@thislg thislg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut faire une nouvelle version pour qu'on puisse l'appliquer sur un projet qui a déjà le docker pack.

… processes

Needed for some processes like Symfony Messenger consume for example.
@lucasmirloup lucasmirloup force-pushed the fix/docker-pack-spells branch from 8b1b7e9 to 2ca1575 Compare October 15, 2024 14:41
@lucasmirloup
Copy link
Member Author

Il faut faire une nouvelle version pour qu'on puisse l'appliquer sur un projet qui a déjà le docker pack.

J'ai créé la v2.3, et j'ai retiré le .spells de la v2.2 (il n'était pas installable car absent du manifest.json :/)

@lucasmirloup lucasmirloup requested a review from thislg October 15, 2024 14:43
@lucasmirloup lucasmirloup requested a review from thislg October 15, 2024 15:14
@thislg thislg merged commit 8a476b0 into main Oct 15, 2024
@thislg thislg deleted the fix/docker-pack-spells branch October 15, 2024 15:19
@lucasmirloup
Copy link
Member Author

Merci @thislg 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docker-pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants