I've added a menu to share when long-pressing a video #1222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I'm working on issue #1133 (#1133)
So far, it's going well. However, there's quite a few ways to implement a menu after a long press. Signal Messenger has a cool UI for when users long click on a message. But other apps like NewPipe just use a dialog to display other options.
To keep things simple, I used a popup menu. I added other menu items that you'd see in the FileViewFragment (download, repost, etc.). I added these because only putting "share" in the menu didn't seem like much of a menu.
(Right now, "Share" is the only menu item that actually works.) Before I keep going, I was looking for some feedback on what I've done so far.
Thanks :)
[PS, I submitted an application to LBRY for an android engineer position on September 9, 2021. This PR is part of my application process.]
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: 1133
What is the current behavior?: Users have to click on a video to use options like sharing
What is the new behavior?: I added a menu so that when users click on a video they can share it without actually clicking on it
Other information