Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rofi Theme selector use only same @theme line if present and create if not. #168

Closed
wants to merge 2 commits into from

Conversation

JaKooLit
Copy link

@JaKooLit JaKooLit commented Feb 7, 2025

Please follow these steps before submitting your PR:

  • This PR targets the wayland branch and not master
  • If your PR is a work in progress, include [WIP] in its title
  • Its commits' summaries are reasonably descriptive
  • You've described what this PR addresses below
  • You've included links to relevant issues, if any with #issue_num
  • You've deleted this template

Thank you for contributing to rofi! <3

This should fix #167

@JaKooLit
Copy link
Author

JaKooLit commented Feb 8, 2025

I have pushed a new MR

it should look like this now

rofi-theme-line

limited to 10 total of lines..

you can of course increase to more than 10 if you wish

@lbonn
Copy link
Owner

lbonn commented Feb 16, 2025

@JaKooLit honestly, given the added bash complexity, I would not merge this.

The current behavior is probably matching what most users need. Users who run this tool often and are bothered by the commented line can easily customize their version of rofi-theme-selector.

@JaKooLit
Copy link
Author

@JaKooLit honestly, given the added bash complexity, I would not merge this.

The current behavior is probably matching what most users need. Users who run this tool often and are bothered by the commented line can easily customize their version of rofi-theme-selector.

sure no worries. Not sure what you mean "complexity" though

anyway, I just modified the theme selector abd Ill offer to my users

@JaKooLit JaKooLit closed this Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants