Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workspace] Converted to Yarn Workspace 3 with Lerna #95

Merged
merged 41 commits into from
Sep 28, 2023
Merged

[workspace] Converted to Yarn Workspace 3 with Lerna #95

merged 41 commits into from
Sep 28, 2023

Conversation

nebula-aac
Copy link
Contributor

@nebula-aac nebula-aac commented Sep 12, 2023 •
edited
Loading

Notes for Reviewers

This PR fixes #5

I have another branch for converting to Yarn 3 Workspace.

Since we're already using Yarn, we can definitely turn this into a true workspace, and use the latest from Yarn 3. This is an optional branch for anyone to review.

Breaking Changes

  • Design System has been moved to apps, make sense to move it here, instead of being involved in the build process. This project has also been migrated to Vite Typescript.
  • svg and components have officially being migrated to use Vite.
  • Two new release workflows to build two of the packages separately
  • Fixed where we can run lint from workspace, which was missing out the linting from each of the packages

UPDATED

  • Updated forked to include the ErrorBoundary in components
  • Updated forked to include rtk-query-codegen
  • Updated ErrorBoundary to define custom type definitions
  • Updated rtk-query-codegen with scripts in place to build

Signed commits

  • Yes, I signed my commits.

@nebula-aac
Converted to Yarn Workspace 3
6f4fce7 
Signed-off-by: Antonette Caldwell <[email protected]>
@leecalcote
Copy link
Member

@Mohith234 you might like to review (even after merge)

@leecalcote
Copy link
Member

This project has also been migrated to Vite Typescript.

✔️

leecalcote
leecalcote reviewed Sep 12, 2023
View reviewed changes
.github/workflows/components-release.yml Outdated
release:
types: [published]
workflow_dispatch:
inputs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While dispatching, if one of the steps here isn't dynamically identifying the latest release tag, we might want to require the release tag as input here.

You might like to grab the release tag lookup "function" from another one of the makefiles / workflows.

@nebula-aac
chore: formatted package.json
35807fe 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
patch: update module exports
108331b 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
prelease components 0.1.1-beta.1
84472ae 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
feat: Created Avatar story
822d809 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
feat: Created Accordion story
e6b814f 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
feat: Created Badge story
15a91b0 
Signed-off-by: Antonette Caldwell <[email protected]>
@saurabh100ni
Copy link

Let's discuss these updates on the website call today
Please add this as an agenda item in the meeting minutes, if you would :)
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@nebula-aac
feat: Grouped Fullscreen icons
cdb3bb8 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore: Minor patch
b7639bd 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore: Upgrade Storybook
e4cd8a4 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
fix: Moved deps to devDeps, and allow them to be peers
704c432 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
feat: Updated Button to allow a label and also take in children
0c25592 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore: published @layer5/[email protected]
f123b5b 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
components: Defined Dialog props, and hardcoded styles for testing
456002b 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
feat: Added Backdrop story
41affa5 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore: Grouped Configuration
fa7a0bf 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore: Grouped Dashboard
6567997 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore: Grouped Zoom icons
29015b4 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore: Grouped Shapes
e34b416 
Signed-off-by: Antonette Caldwell <[email protected]>
@leecalcote leecalcote mentioned this pull request Sep 27, 2023
Open
@nebula-aac nebula-aac self-assigned this Sep 28, 2023
This was referenced Sep 28, 2023
Closed
Open
@nebula-aac nebula-aac changed the title [workspace] Converted to Yarn Workspace 3 [optional] [workspace] Converted to Yarn Workspace 3 Sep 28, 2023
@nebula-aac nebula-aac changed the title [workspace] Converted to Yarn Workspace 3 [workspace] Converted to Yarn Workspace 3 with Lerna Sep 28, 2023
@nebula-aac
feat: Update lerna to build in root workspace
42bf34a 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore: Added script to clean node_modules with lerna
bf42b7e 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
update fork
9c7f2f7 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
feat: Created release github action
a9f205e 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore: Renamed release to checks
48b2189 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore(ci): added step to do prettier check
0e74c68 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore(ci): removed other release actions, and created single release
eef0557 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore(workspace): Added publish command to lerna
4b6a1fe 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
feat(ci): Update release to publish npm package by way lerna
5e9f98a 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore(rtk-query-codegen): Update README and fix grammatical errors. A…
7d993b7 
…lso removed numbered ordered list

Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac nebula-aac merged commit b3c9b58 into master Sep 28, 2023
5 checks passed
This was referenced Sep 28, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

Assignees

@nebula-aac nebula-aac

Labels
area/ci Continuous integration | Build and release component/components component/icons framework/storyboard
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decide on project layout and package manager
3 participants
@nebula-aac @leecalcote @saurabh100ni