Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Twitter logo to X #336

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

akhilender-bongirwar
Copy link
Member

Description

  • Updated the Twitter logo on the GetNighthawk.dev website from the old logo to the new X logo.
  • This change aligns with the desired state of the website and ensures consistency with branding.

This PR fixes #325

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

In response to user feedback, this commit addresses the spacing concerns within the GetNighthawk website's UI. The existing design was visually appealing but lacked sufficient spacing between certain components.

Changes Made:
- Added margin-bottom to the analysis, distribution, and standards-based cards to create a clear distinction between them and improve readability.
- Introduced appropriate spacing between the 'Nighthawk & Meshery' section and the 'Layer 7 Performance Analysis' division to enhance the overall visual balance.

These adjustments have been carefully implemented to maintain the smooth and polished UI while ensuring a more comfortable viewing experience for users. The improved spacing creates a harmonious layout, allowing each component to breathe and stand out effectively.

Resolves Issue: layer5io#290

Signed-off-by: Akhilender [email protected]
Signed-off-by: Akhilender <[email protected]>
Refactored the CSS code to introduce a custom scrollbar consistent with modern design trends. The new scrollbar design aligns with the desired appearance, replacing the default one.

Changes Made:
- Added custom scrollbar CSS rules.
- Removed the default scrollbar appearance.

These adjustments have been carefully implemented to maintain the smooth
and polished UI.

Resolves Issue: layer5io#327

Signed-off-by: Akhilender <[email protected]>
- Updated the Twitter logo on the GetNighthawk.dev website from the old logo to the new X logo.
- This change aligns with the desired state of the website and ensures consistency with branding.

Fixes layer5io#325

Signed-off-by: Akhilender <[email protected]>
@netlify
Copy link

netlify bot commented Sep 7, 2023

Website preview ready!

Name Link
🔨 Latest commit 5464f6b
🔍 Latest deploy log https://app.netlify.com/sites/getnighthawk/deploys/651c1e998ef6e300089c8a18
😎 Deploy Preview https://deploy-preview-336--getnighthawk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- Removed the redundant css code for custom scrollbar 


Signed-off-by: Akhilender Bongirwar <[email protected]>
- Changed back the css of index.scss to its original state.
- Removed the changes related to the other issue

Signed-off-by: Akhilender Bongirwar <[email protected]>
Copy link
Contributor

@abhijeetgauravm abhijeetgauravm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @akhilender-bongirwar your branch having other commits also beside the required changes needed for the issue. U should create separate branches for resolving different issues!

@akhilender-bongirwar
Copy link
Member Author

akhilender-bongirwar commented Sep 9, 2023

Hey @abhijeetgauravm , actually I have created separate branches as you can see

  • this issue is from icon branch
  • custom scrollbar issue from customscrollbar branch
  • margin issue from addspacing branch.

But yeah the changes from the other branch also came.

@Ghat0tkach
Copy link
Member

hey @akhilender-bongirwar

Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@akhilender-bongirwar
Copy link
Member Author

Hey @abhijeetgauravm , could you please review this PR : )

Copy link
Contributor

@abhijeetgauravm abhijeetgauravm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution @akhilender-bongirwar

@Savio629
Copy link
Member

Savio629 commented Oct 2, 2023

@akhilender-bongirwar Can you revert the index.scss changes ? Everything else looks fine.

Signed-off-by: Akhilender Bongirwar <[email protected]>
@vishalvivekm
Copy link
Member

@akhilender-bongirwar

the current on-hover effect (color) on X logo isn't ideal.
Refer to the meshery.io socials in footer and implement the same for X logo here.

- Implemented a white color fill on hover.
- Aligns with design standards of hover effect of meshery.io

Signed-off-by: Akhilender Bongirwar <[email protected]>
@akhilender-bongirwar
Copy link
Member Author

@vishalvivekm , could you please review this ?

@iArchitSharma
Copy link

@akhilender-bongirwar hover effect doesn't work and and no twitter handle is linked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update Twitter Logo to X(New logo)
6 participants