-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document task pane #2381
Document task pane #2381
Conversation
I've pushed a change to fix scrolling. I find it pretty confusing - you have to prevent one of the ancestor containers from trying to grow, to allow a descendant to realise it needs to scroll. |
First prize is if the normal task view uses the same timeline and button templates. I'm not sure how complex that is -- so that we don't have duplicate ways of showing almost identical information. |
100%, working on that
|
An option for the logged-out thing is to change the behaviour on the base authenticated view mixin: if the request is HTMX, then rather than redirecting to the login view simply return a very simple "Permission denie" 403 response. |
This is looking great - #2383 opened to resolve I think all the outstanding issue. HTMX is awesome. Please also remove the old "Tasks" link in the menu bar, it's now redundant. |
ensure the comment form validates when just posting a comment
Thank you! I've taken it for a spin and it seems all good now 🙌 |
closes #2322
https://www.loom.com/share/44bcaefe33bc4aa2a9a50687adf27623
TODO: