Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document task pane #2381

Merged
merged 19 commits into from
Mar 19, 2025
Merged

Document task pane #2381

merged 19 commits into from
Mar 19, 2025

Conversation

goose-life
Copy link
Contributor

@goose-life goose-life commented Mar 5, 2025

closes #2322

https://www.loom.com/share/44bcaefe33bc4aa2a9a50687adf27623

TODO:

  • add submission buttons
  • fix scrolling
  • deal with empty comment (disable button if there's no comment? do nothing?)
  • deal with logged-out user submitting task within a document (don't load login page, don't redirect to template partial)

Sorry, something went wrong.

@goose-life goose-life requested a review from longhotsummer March 5, 2025 10:25
Copy link

github-actions bot commented Mar 5, 2025

Test Results

581 tests  ±0   581 ✅ ±0   4m 15s ⏱️ -23s
 60 suites ±0     0 💤 ±0 
 60 files   ±0     0 ❌ ±0 

Results for commit d33cfc1. ± Comparison against base commit 0fd8beb.

♻️ This comment has been updated with latest results.

@longhotsummer
Copy link
Contributor

longhotsummer commented Mar 6, 2025

I've pushed a change to fix scrolling. I find it pretty confusing - you have to prevent one of the ancestor containers from trying to grow, to allow a descendant to realise it needs to scroll.

@longhotsummer
Copy link
Contributor

First prize is if the normal task view uses the same timeline and button templates. I'm not sure how complex that is -- so that we don't have duplicate ways of showing almost identical information.

@goose-life
Copy link
Contributor Author

goose-life commented Mar 6, 2025 via email

@goose-life
Copy link
Contributor Author

@longhotsummer
Copy link
Contributor

An option for the logged-out thing is to change the behaviour on the base authenticated view mixin: if the request is HTMX, then rather than redirecting to the login view simply return a very simple "Permission denie" 403 response.

@longhotsummer
Copy link
Contributor

This is looking great - #2383 opened to resolve I think all the outstanding issue. HTMX is awesome.

Please also remove the old "Tasks" link in the menu bar, it's now redundant.

image

longhotsummer and others added 2 commits March 19, 2025 11:23
@goose-life
Copy link
Contributor Author

Thank you! I've taken it for a spin and it seems all good now 🙌

@goose-life goose-life merged commit 5ca55fa into master Mar 19, 2025
5 checks passed
@goose-life goose-life deleted the document-task-pane branch March 19, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show tasks in the document view
2 participants