Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: PRT - QoS Manager refactor #1908

Merged
merged 29 commits into from
Jan 28, 2025
Merged

refactor: PRT - QoS Manager refactor #1908

merged 29 commits into from
Jan 28, 2025

Conversation

shleikes
Copy link
Collaborator

No description provided.

@shleikes shleikes requested a review from ranlavanet January 13, 2025 16:12
@shleikes shleikes self-assigned this Jan 13, 2025
@shleikes shleikes marked this pull request as ready for review January 13, 2025 16:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

Test Results

2 515 tests  +23   2 515 ✅ +23   27m 31s ⏱️ +16s
  123 suites + 1       0 💤 ± 0 
    7 files   ± 0       0 ❌ ± 0 

Results for commit 9535f6e. ± Comparison against base commit 3a2b885.

This pull request removes 2 and adds 25 tests. Note that renamed tests count towards both. 
github.com/lavanet/lava/v4/protocol/lavasession ‑ TestCalculateAvailabilityScore
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestExcellence

github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestReputation
github.com/lavanet/lava/v4/protocol/qos ‑ TestAddFailedRelay
github.com/lavanet/lava/v4/protocol/qos ‑ TestCalculateAvailabilityScore
github.com/lavanet/lava/v4/protocol/qos ‑ TestCalculateQoS
github.com/lavanet/lava/v4/protocol/qos ‑ TestEdgeCaseLatencies
github.com/lavanet/lava/v4/protocol/qos ‑ TestEdgeCaseLatencies/Equal_Latencies
github.com/lavanet/lava/v4/protocol/qos ‑ TestEdgeCaseLatencies/Extremely_High_Latency
github.com/lavanet/lava/v4/protocol/qos ‑ TestEdgeCaseLatencies/Negative_Expected_Latency
github.com/lavanet/lava/v4/protocol/qos ‑ TestEdgeCaseLatencies/Zero_Latency
github.com/lavanet/lava/v4/protocol/qos ‑ TestHighConcurrencyScenario
…

♻️ This comment has been updated with latest results.

@ranlavanet ranlavanet self-assigned this Jan 28, 2025
ranlavanet
ranlavanet requested changes Jan 28, 2025
View reviewed changes
protocol/common/endpoints.go Show resolved Hide resolved
protocol/lavasession/consumer_session_manager.go Show resolved Hide resolved
protocol/lavasession/single_consumer_session.go Outdated Show resolved Hide resolved
protocol/qos/common.go Outdated Show resolved Hide resolved
protocol/rpcconsumer/relay_errors.go Outdated Show resolved Hide resolved
protocol/rpcconsumer/rpcconsumer_server.go Outdated Show resolved Hide resolved
@ranlavanet ranlavanet self-requested a review January 28, 2025 14:16
@ranlavanet ranlavanet merged commit 20ec632 into main Jan 28, 2025
27 of 29 checks passed
@ranlavanet ranlavanet deleted the PRT-qos-manager-refactor branch January 28, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranlavanet ranlavanet ranlavanet approved these changes

Assignees

@shleikes shleikes

@ranlavanet ranlavanet

Labels
C:protocol C:x/pairing size/XXL Team:Consensus Team:Protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shleikes @ranlavanet