Make Encode return a result #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FSMaxB
force-pushed
the
fallible-encode
branch
3 times, most recently
from
9dde82f
to
4a5a6bd
Compare
|
Getting the macros to work again is really tricky as it turns out! |
FSMaxB
force-pushed
the
fallible-encode
branch
7 times, most recently
from
e831255
to
c9226b1
Compare
FSMaxB
commented
Apr 10, 2024
abonander
reviewed
Apr 12, 2024
abonander
reviewed
Apr 12, 2024
abonander
reviewed
Apr 12, 2024
abonander
reviewed
Apr 12, 2024
abonander
reviewed
Apr 12, 2024
abonander
reviewed
Apr 12, 2024
abonander
requested changes
Apr 12, 2024
FSMaxB
force-pushed
the
fallible-encode
branch
5 times, most recently
from
c502a9a
to
a1074be
Compare
This only changes the trait for now and makes it compile, calling .expect() on all users. Those will be removed in a later commit.
This pushes the panics one level further to mostly bind calls. Those will also be removed later.
FSMaxB
force-pushed
the
fallible-encode
branch
2 times, most recently
from
7de461a
to
d73561f
Compare
|
@abonander I believe I have addressed all review comments, so this is ready for another round of review. |
abonander
requested changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2730
Still working on this, but wanted to make a draft PR where I can push my current progress.My approach was to incrementally turn return values into
Resultin one layer, but keeping the panic by calling.expect(...)on the layers that use those, then go to the next layer and turn the.expect(...)into?and push the panics up further and further until they're gone.I'll leave some open questions as review comments.