fix(sqlx-cli): do not clean sqlx during prepare #2786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
cargo sqlx prepare --workspace
runningcargo clean -p sqlx
unnecessarily.See #2785
This should be a non-breaking change. It shouldn't affect in-workspace dependencies that happen to be named
sqlx
either.How to test or review this PR
sqlx-cli
.cargo sqlx prepare --workspace
in a project with crates that usequery!
macros.The timing difference is quite significant in a larger workspace, saves ~40 seconds on an incremental build.
BEFORE:
AFTER (this PR, note there is no cleaning step):