Add MySql LOCAL INFILE functionality #2738
Conversation
|
I like the functionality of LocalInfileHandler that doesn't tie the local implementation to a local file, just a handler to push data. This should mitigate the risks of enabling localinfile as default in the protocol. |
jelle-bigbridge
force-pushed
the
add-local-infile
branch
from
0cc0db7
to
b3b4d10
Compare
jelle-bigbridge
force-pushed
the
add-local-infile
branch
from
380288b
to
d09f675
Compare
jelle-bigbridge
force-pushed
the
add-local-infile
branch
4 times, most recently
from
03a7c85
to
7f016e8
Compare
jelle-bigbridge
force-pushed
the
add-local-infile
branch
from
7f016e8
to
f9cf34e
Compare
|
@abonander could you look at the changes I made? |
| let mut send = SendPacket::new(buf, self.stream.sequence_id); | ||
| self.stream.sequence_id = self.stream.sequence_id.wrapping_add(1); | ||
| // Try to poll the send future right now | ||
| match Pin::new(&mut send).poll_send(cx, self.stream.socket_mut()) { |
There was a problem hiding this comment.
Why are you bypassing the connection's internal buffer?
There was a problem hiding this comment.
My idea was that you either use the "easy" way of calling MySqlLocalInfile::send a couple times, which does buffering, or you want to do a different style of buffering so you need a "direct" API. In my own usage, I wrap the "direct" writer with my own BufWriter to provide buffering of infile packets.
There was a problem hiding this comment.
My thought is, we already have a perfectly buffer in the connection. Why force the user to allocate another?
|
Sorry for answering with my personal account @pingiun. I plan to migrate my work account to personal in the future. |
Co-authored-by: Austin Bonander <[email protected]>
Co-authored-by: Austin Bonander <[email protected]>
|
@abonander what is needed to get this merged? |
Fixes #1766
I've added a test which confirms this functionality. I was unsure about the function name
local_infile_statementand the trait nameMySqlExecutorInfileExt. Please tell me if you want to have different names