Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support For Postgres Full Text Search tsvector Data Type #2727

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add Support For Postgres Full Text Search tsvector Data Type #2727

wants to merge 18 commits into from

Conversation

anshap1719
Copy link

@anshap1719 anshap1719 commented Sep 1, 2023 •
edited

Closes #2705

Relates to #729

@anshap1719 anshap1719 marked this pull request as ready for review September 4, 2023 12:33
@anshap1719 anshap1719 changed the title Add Support For Postgres Full Text Search Add Support For Postgres Full Text Search Data Types Sep 4, 2023
abonander
abonander requested changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it appears that supporting full text search does not require enabling any optional dependencies, it doesn't need a feature flag. It's perfectly fine for it to be unconditionally compiled, like with the support for ltree and lquery.

sqlx-core/Cargo.toml Outdated Show resolved Hide resolved
@anshap1719
Copy link
Author

Hi @abonander, please approve the workflow run, it should now be fixed.

@anshap1719
Copy link
Author

Hi @abonander, Did you get a chance to look at this again yet?

@abonander
Copy link
Collaborator

I review PRs as I get to them. SQLx is only a small part of my full-time job. Pinging me just fills up my notifications, it won't get your PR reviewed any faster.

@anshap1719
Copy link
Author

@abonander I understand. Apologies for bothering you with those.

@anshap1719 anshap1719 closed this Nov 23, 2023
@anshap1719 anshap1719 reopened this Feb 1, 2024
@abonander
Copy link
Collaborator

@anshap1719 can you please rebase and fix conflicts one last time? We're ready to merge this.

Note that the type mappings for the macros have moved to their corresponding database drivers:

sqlx/sqlx-postgres/src/type_checking.rs

Line 10 in 02c68a4

impl_type_checking!(

@anshap1719
Copy link
Author

Thanks @abonander, I have updated this PR.

@abonander
Copy link
Collaborator

Looks like cargo fmt needs to be run.

@anshap1719
Copy link
Author

@abonander Right, my bad. Done now.

wyhaya
wyhaya reviewed Mar 31, 2024
View reviewed changes
sqlx-postgres/src/types/ts_vector.rs Show resolved Hide resolved
sqlx-postgres/src/types/ts_vector.rs Outdated Show resolved Hide resolved
sqlx-postgres/src/types/ts_vector.rs Outdated Show resolved Hide resolved
sqlx-postgres/src/types/ts_vector.rs Outdated Show resolved Hide resolved
@anshap1719
Copy link
Author

@wyhaya Thanks for the review. Will make the changes over the weekend and will also use all the cases you described as test cases.

@anshap1719
Copy link
Author

@wyhaya Updated everything. Thanks for the code as well.

@anshap1719 anshap1719 requested a review from wyhaya April 8, 2024 12:54
wyhaya
wyhaya reviewed Apr 8, 2024
View reviewed changes
sqlx-postgres/src/types/ts_vector.rs Outdated Show resolved Hide resolved
sqlx-postgres/src/types/ts_query.rs Outdated Show resolved Hide resolved
@anshap1719
Copy link
Author

Hi @abonander Just FYI, this PR no longer covers tsquery. I removed it since I realized it's not ready and needs a lot of work, and the tsvector is already done and we want to avoid blocking that.

@anshap1719 anshap1719 requested a review from wyhaya April 21, 2024 08:50
@anshap1719 anshap1719 changed the title Add Support For Postgres Full Text Search Data Types Add Support For Postgres Full Text Search tsvector Data Type Apr 21, 2024
@anshap1719
WIP: Remove Unimplemented TsQuery Definitions launchbadge#2705
b98a3eb
@anshap1719
Revert "WIP: Remove Unimplemented TsQuery Definitions launchbadge#2705"
c4b2274 
This reverts commit 279868a.
@anshap1719
WIP: Add Support For Decoding And Encoding TsQuery launchbadge#2705
6abc12f
@anshap1719
WIP: Add Missing Exports For TsQuery launchbadge#2705
612a452
@anshap1719
WIP: Fix Build Issues, Add Tests For TsVector launchbadge#729,launchb…
8071cac 
…adge#2705
@anshap1719
Remove Feature Flag For Postgres Full Text Search Data Types launchba…
032f8ba 
…dge#729,launchbadge#2705
@anshap1719
Update Type For Pg Argument Buffer launchbadge#729,launchbadge#2705
8166072
@anshap1719
Run cargo fmt
1ce2f7d
@anshap1719
Add Support For Weights In Word Positions launchbadge#729,launchbadge…
bf67dfa 
…#2705
@anshap1719
Fix Clippy Lint Warning launchbadge#729,launchbadge#2705
65a8267
@anshap1719
Add Handling For Whitespace Inside TSVector Words launchbadge#729,lau…
5ac77d0 
…nchbadge#2705
@anshap1719
Remove Incomplete TSQuery Implementation launchbadge#729,launchbadge#…
a85c27f 
…2705
@anshap1719
Add Proper Handling For Escaped And Non-Escaped Single Quotes In TSVe…
570216b 
…ctor Words launchbadge#729,launchbadge#2705
@anshap1719 anshap1719 requested a review from wyhaya April 28, 2024 10:45
@KirDontsov
Copy link

Oh, guys sorry, but I really need tsvector support, can you check and merge it? @abonander

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonander abonander Awaiting requested review from abonander

@wyhaya wyhaya Awaiting requested review from wyhaya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postgres TSVector Support
4 participants
@anshap1719 @abonander @KirDontsov @wyhaya