Fix: error thrown when there are no changes to revert #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -191,9 +191,5 @@ export async function computeChangesToRevertCommit( | |||
| targetDraftDocuments: documentsInDraft.value, | |||
| }) | |||
|
|
|||
| if (changesToRevert.length === 0) { | |||
| return Result.error(new ConflictError('No changes to revert')) | |||
There was a problem hiding this comment.
I think here you can throw the error and will arrive to onError Can you check?
There was a problem hiding this comment.
It does arrive to the onError handler, yes, but the sentry notification would already have been sent
There was a problem hiding this comment.
Talked offline. We're over catching errors on NextJS action sentry procedure. We should avoid catching these kind of errors that are not bugs and are intended to be shown to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.