Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0 (2016 Season) #51

Merged
merged 22 commits into from
Sep 15, 2016
Merged

Release 1.0 (2016 Season) #51

merged 22 commits into from
Sep 15, 2016

Conversation

ehsanmasdar
Copy link
Member

@ehsanmasdar ehsanmasdar commented Sep 14, 2016

Update for 2016-2017 Season:

  • Updated to newest FIRST library release
  • Requires Android Studio 2.0 or greater

@ehsanmasdar
Copy link
Member Author

@smo-key We should do the thing, you approve?

@smo-key
Copy link
Member

smo-key commented Sep 14, 2016

@ehsanmasdar Can you write a line-item description for this? Seems like there are a whole lot more commits than just those to update the library version.

@ehsanmasdar
Copy link
Member Author

@smo-key That was all done last season and never made it into master. I can't tackle a changelog right now but I'll look into it later.

Copy link
Member

@smo-key smo-key left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehsanmasdar Looks good! 👍

No breaking changes.

@@ -4,7 +4,7 @@ buildscript {
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:1.3.0'
classpath 'com.android.tools.build:gradle:2.1.3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: May require Android Studio 2.0+.

@@ -73,7 +73,7 @@ public void reset() {
* @return The offset gyroscope rotation in degrees per second
*/
public double getRate() {
return gyroSensor.getRotation() - offset;
return gyroSensor.getHeading() - offset;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly changes behavior of getRate() (probably for the better).

@smo-key
Copy link
Member

smo-key commented Sep 14, 2016

@ehsanmasdar Do the honors. :)

@smo-key smo-key changed the title Release Release 1.0 (2016 Season) Sep 14, 2016
@ehsanmasdar
Copy link
Member Author

@homu r+

On Wed, Sep 14, 2016, 6:01 PM Arthur Pachachura [email protected]
wrote:

@ehsanmasdar https://github.com/ehsanmasdar Do the honors. :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#51 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABRJHNuxqgLH5Oq5B7ktCJAta-oMkF21ks5qqG67gaJpZM4J9QEh
.

@ehsanmasdar
Copy link
Member Author

@homu :(

@smo-key
Copy link
Member

smo-key commented Sep 14, 2016

RIP @homu

@smo-key
Copy link
Member

smo-key commented Sep 14, 2016

@homu r+

@homu
Copy link
Contributor

homu commented Sep 14, 2016

📌 Commit bcb2365 has been approved by smo-key

homu added a commit that referenced this pull request Sep 14, 2016
Release 1.0 (2016 Season)

Update for **2016-2017 Season**:

- Updated to newest FIRST library release
- Requires Android Studio 2.0 or greater
homu added a commit that referenced this pull request Sep 14, 2016
Release 1.0 (2016 Season)

Update for **2016-2017 Season**:

- Updated to newest FIRST library release
- Requires Android Studio 2.0 or greater
@homu
Copy link
Contributor

homu commented Sep 14, 2016

⌛ Testing commit bcb2365 with merge b1fdedf...

@smo-key
Copy link
Member

smo-key commented Sep 14, 2016

@ehsanmasdar Check to make sure you have privileges to Homu.

@smo-key
Copy link
Member

smo-key commented Sep 14, 2016

@ehsanmasdar I think @homu is broken.

@ehsanmasdar ehsanmasdar merged commit 15cda0c into master Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants