-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FIRST libraries #49
Conversation
also, why is there a folder named skynet under your library? things are not quite as they seem lol. |
Is this a reply to me or the respiratory in rhsnutrons On Sep 11, 2016 1:58 AM, "buggy213" [email protected] wrote:
|
Um. This is a pull request for this repo to update the libaries to the newest official FIRST ones. I'm from team The Clueless |
Is this repository still active? |
16-17 is active also it's base code we took from first On Sep 11, 2016 2:08 AM, "buggy213" [email protected] wrote:
|
Cool. Our team looks forward to using this for our robot |
It appears there are several issues regarding the EncodedMotors.java class and the fact that the DcMotor class has been turned into an abstract class. I will look into this further tomorrow. |
Ok, the issues should be fixed now, although Travis CI is still spitting out errors because this repo is still using a old version of Gradle |
Hello @buggy213. Please try again by setting the Gradle version to Note: you may need Android Studio 2 or higher in order to use the newer version of Gradle. If you have trouble, let us know what version of Android Studio you used, then update to the latest version. |
@@ -65,14 +66,14 @@ public boolean hasReachedPosition(double position) { | |||
|
|||
public void enableEncoder() { | |||
//This command requires (at least ?) one execution loop to reset the encoders | |||
super.setMode(DcMotorController.RunMode.RUN_USING_ENCODERS); | |||
super.setMode(RunMode.RUN_WITHOUT_ENCODER); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@buggy213 Is this supposed to be RUN_WITH_ENCODER
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, good catch
☔ The latest upstream changes (presumably #50) made this pull request unmergeable. Please resolve the merge conflicts. |
Fixed in #50 |
Exactly as the title says.