Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FIRST libraries #49

Closed
wants to merge 4 commits into from

Conversation

buggy213
Copy link

Exactly as the title says.

@buggy213
Copy link
Author

also, why is there a folder named skynet under your library? things are not quite as they seem lol.

@KevinHenriquez
Copy link

Is this a reply to me or the respiratory in rhsnutrons

On Sep 11, 2016 1:58 AM, "buggy213" [email protected] wrote:

also, why is there a folder named skynet under your library? things are
not quite as they seem lol.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#49 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP8AJOCEOzr2i38RltgmjUkzV3baRhtsks5qo5iFgaJpZM4J56uw
.

@buggy213
Copy link
Author

Um. This is a pull request for this repo to update the libaries to the newest official FIRST ones. I'm from team The Clueless

@buggy213
Copy link
Author

Is this repository still active?

@KevinHenriquez
Copy link

16-17 is active also it's base code we took from first

On Sep 11, 2016 2:08 AM, "buggy213" [email protected] wrote:

Is this repository still active?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#49 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP8AJCVROO7wii2LACWt27S9d8Sit-6Dks5qo5rAgaJpZM4J56uw
.

@ehsanmasdar
Copy link
Member

ehsanmasdar commented Sep 11, 2016

Hi @buggy213. Thanks for the PR. I'll get this looked at and merged in ASAP. CC @smo-key

@buggy213
Copy link
Author

Cool. Our team looks forward to using this for our robot

@buggy213
Copy link
Author

It appears there are several issues regarding the EncodedMotors.java class and the fact that the DcMotor class has been turned into an abstract class. I will look into this further tomorrow.

@buggy213
Copy link
Author

buggy213 commented Sep 11, 2016

Ok, the issues should be fixed now, although Travis CI is still spitting out errors because this repo is still using a old version of Gradle

@smo-key
Copy link
Member

smo-key commented Sep 11, 2016

Hello @buggy213. Please try again by setting the Gradle version to 2.14.1 in /home/travis/build/lasarobotics/FTCLibrary/ftc-library/build.gradle and any other Gradle file in the repo.

Note: you may need Android Studio 2 or higher in order to use the newer version of Gradle. If you have trouble, let us know what version of Android Studio you used, then update to the latest version.

@@ -65,14 +66,14 @@ public boolean hasReachedPosition(double position) {

public void enableEncoder() {
//This command requires (at least ?) one execution loop to reset the encoders
super.setMode(DcMotorController.RunMode.RUN_USING_ENCODERS);
super.setMode(RunMode.RUN_WITHOUT_ENCODER);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buggy213 Is this supposed to be RUN_WITH_ENCODER?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, good catch

@homu
Copy link
Contributor

homu commented Sep 14, 2016

☔ The latest upstream changes (presumably #50) made this pull request unmergeable. Please resolve the merge conflicts.

@ehsanmasdar
Copy link
Member

Fixed in #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants