Adds options menu to library #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menu is now extensible to allow for different input types. Sample Categories included are: Single select dropdown Text input Number only input
|
@Oksisane everything looks good to me after a quick scan |
|
I trust you three. I am still a bit behind on the library. Now, if On Wed, Oct 14, 2015 at 11:23 PM, Shwinn [email protected] wrote:
|
|
👍 |
|
📌 Commit efc64fc has been approved by |
homu
added a commit
that referenced
this pull request
Oct 15, 2015
Adds options menu to library @smo-key Please review and sign off. @ethan-schaffer @Shwinn Also please code review.
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@smo-key Please review and sign off.
@ethan-schaffer @Shwinn Also please code review.