Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only add js (checked by hash) once #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morksinaanab
Copy link

This solves issue #110

Queued tasks add the JS code multiple times. The fix keeps track of each js that is to be added with an array with hashes in the $view data. If there already is a hash for the js code, skip it. It seems todo the trick.

It's not really a solution to the problem that the queue is adding multiple (unnecessary) listeners, but it is a failsafe.

…ded through queued tasks adding more than once
@morksinaanab morksinaanab changed the title only add js (checked by hash) once - to prevent multiple listeners ad… only add js (checked by hash) once Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant