Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPStorm Intellisense for put() method #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eberkund
Copy link

@eberkund eberkund commented May 31, 2018

PHPStorm complains about passes arguments to a function with no parameters. This is because the put() method uses func_get_args() to dynamically retrieve args from the caller.

screen shot 2018-06-03 at 3 08 08 am

I followed the suggestion on this Stack Overflow answer and it fixes the issue. I am also using Laravel IDE helper.

@eberkund
Copy link
Author

eberkund commented Jun 2, 2018

With regards to the failing CI checks, this PR removes support for PHP 5.5 which I think is okay given its unsupported at this point so I expect that to fail. And the HVVM check was already broken prior to this it looks like.

@rdarcy1
Copy link

rdarcy1 commented Sep 5, 2019

@JeffreyWay would you consider merging this? I find the package very useful and would be great if the static analysis didn't warn for every put() call with an argument. Thanks!

@AndreasHerss
Copy link

This would be awesome if it could get merged! 😍

@GregMayes
Copy link

Would also love to see this get merged. From a static analysis standpoint, It's a lot more transparent than func_get_args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants