Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NASA] Add target water temperature #95

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[NASA] Add target water temperature #95

wants to merge 3 commits into from

Conversation

Mongey
Copy link
Contributor

@Mongey Mongey commented Feb 12, 2024 •
edited
Loading

Screenshot 2024-02-12 at 13 25 21

@Mongey Mongey changed the title Add target water temperature [NASA] Add target water temperature Feb 12, 2024
lanwin
lanwin requested changes Feb 12, 2024
View reviewed changes
Copy link
Owner

@lanwin lanwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that pullrequest. I added two changed requests.

components/samsung_ac/protocol_nasa.cpp Outdated Show resolved Hide resolved
components/samsung_ac/protocol.h
@@ -84,6 +85,7 @@ namespace esphome
optional<bool> power;
optional<Mode> mode;
optional<float> target_temp;
optional<float> target_water_temp;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added the water temperature to the request, but you did not extended the code witch sents the request.

Please also add a not supported message to non_nasa code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 I'm not sure where to add the "not supported message to non_nasa code" -- can you link to an example ?
same for water temp

@lanwin
Copy link
Owner

lanwin commented Feb 26, 2024

@Mongey did you had time to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanwin lanwin lanwin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mongey @lanwin