Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix units copy constructor issue #33

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Fix units copy constructor issue #33

merged 3 commits into from
Dec 31, 2024

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Dec 31, 2024 •
edited
Loading

Background

@shengtai noticed a bug when retrieving Units objects from Params

Description of Changes

I mistakenly conflated {} with = default when decorating the Units and Constants copy constructors with KOKKOS_FUNCTION. This PR fixes that and I tested that Units has correctly initialized memory now when retrieved from Params.

Checklist

  • New features are documented
  • Tests added for bug fixes and new features
  • (@lanl.gov employees) Update copyright on changed files

@brryan brryan added the bug Something isn't working label Dec 31, 2024
@adamdempsey90 adamdempsey90 merged commit 58815b4 into develop Dec 31, 2024
4 checks passed
@adamdempsey90 adamdempsey90 deleted the brryan/units_get_test branch December 31, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdempsey90 adamdempsey90 adamdempsey90 approved these changes

@shengtai shengtai Awaiting requested review from shengtai

@pdmullen pdmullen Awaiting requested review from pdmullen

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brryan @adamdempsey90