Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chicoma CPU fix #12

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Chicoma CPU fix #12

merged 1 commit into from
Nov 20, 2024

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Nov 19, 2024 •
edited
Loading

Background

Gennaro noticed that our chicoma CPU builds are failing, because it can't find HDF5 without help.

Description of Changes

  • Add chicoma-cpu-debug and chicoma-cpu-release cmake presets
  • Set suite to chicoma-cpu in env/bash

Checklist

  • New features are documented
  • Tests added for bug fixes and new features
  • (@lanl.gov employees) Update copyright on changed files

adamdempsey90
adamdempsey90 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@adamdempsey90 adamdempsey90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my fault that this slipped through the preset cracks. Thanks for fixing it

@brryan brryan merged commit a93dc69 into develop Nov 20, 2024
4 checks passed
@brryan brryan deleted the brryan/chicoma-cpu-fix branch November 20, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdempsey90 adamdempsey90 adamdempsey90 approved these changes

@pdmullen pdmullen Awaiting requested review from pdmullen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brryan @adamdempsey90