[Python] evaluate()
#542
Merged
[Python] evaluate()
#542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinthornw
commented
Mar 25, 2024
hinthornw
commented
Mar 25, 2024
hinthornw
added a commit
that referenced
this pull request
Mar 25, 2024
Also auto-trace in the runevaluator if possible Related to: #542
hinthornw
commented
Mar 26, 2024
| reference_example_id = langsmith_extra.get("reference_example_id") | ||
| id_ = langsmith_extra.get("run_id") | ||
| if ( | ||
| not project_cv |
There was a problem hiding this comment.
Still trace if you're manually providing example, project, etc. via the context var
hinthornw
force-pushed
the
wfh/eval2.0
branch
2 times, most recently
from
1c03f7f
to
18bfc35
Compare
agola11
reviewed
Mar 26, 2024
Comment on lines
407
to
423
| if isinstance(project, uuid.UUID) or _is_uuid(project): | ||
| runs = client.list_runs(project_id=project) | ||
| else: | ||
| runs = client.list_runs(project_name=project) | ||
|
|
||
| treemap: DefaultDict[uuid.UUID, List[schemas.Run]] = collections.defaultdict(list) | ||
| results = [] | ||
| all_runs = {} | ||
| for run in runs: | ||
| if run.parent_run_id is not None: | ||
| treemap[run.parent_run_id].append(run) | ||
| else: | ||
| results.append(run) | ||
| all_runs[run.id] = run | ||
| for run_id, child_runs in treemap.items(): | ||
| all_runs[run_id].child_runs = sorted(child_runs, key=lambda r: r.dotted_order) | ||
| return results |
There was a problem hiding this comment.
why don't we just map trace_id to list of runs, then sort each entry based on dotted order?
There was a problem hiding this comment.
Still need to reconstruct the tree right? It can be nested at an arbitrary depth
I could also just default to only the roots, which is all people need in 90% of usage rn
| TARGET_T = PIPELINE_T | ||
| # dataset-name, dataset_id, or examples | ||
| DATA_T = Union[str, uuid.UUID, Iterable[schemas.Example]] | ||
| SUMMARY_EVALUATOR_T = Callable[ |
There was a problem hiding this comment.
What is summary evaluator?
There was a problem hiding this comment.
aggregate level over whole experiment
agola11
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evaluateapiFeedback I'd love (all welcome)
predict, evaluatevs. 1...)To add in a second PR: